Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(docs) Move pbcopy to right place in example #84

Merged
merged 1 commit into from
May 24, 2023
Merged

(docs) Move pbcopy to right place in example #84

merged 1 commit into from
May 24, 2023

Conversation

mogoodrich
Copy link
Member

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

Screenshots

Related Issue

Other

@@ -75,8 +75,8 @@ yarn link `path/to/openmrs-form-engine-lib`
For example, if you are working on the `openmrs-esm-form-builder` module, you would run the following command:

```bash
pwd | pbcopy # copy the path to form-engine-lib to the to the clipboard
cd `path/to/openmrs-esm-form-builder`
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samuelmale @denniskigen @ibacher I think this was backwards? (note I didn't test, as I don't have pbcopy on my machine... I'm guessing that's a macOS command?)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, looks backwards to me...

@github-actions
Copy link

Size Change: 0 B

Total Size: 547 kB

ℹ️ View Unchanged
Filename Size
dist/225.js 9.82 kB
dist/272.js 6.59 kB
dist/290.js 81.1 kB
dist/294.js 2.63 kB
dist/366.js 6.94 kB
dist/591.js 2.96 kB
dist/595.js 106 kB
dist/634.js 821 B
dist/692.js 34.5 kB
dist/709.js 2.42 kB
dist/986.js 193 kB
dist/main.js 97.6 kB
dist/openmrs-form-engine-lib.js 3.25 kB

compressed-size-action

@ibacher ibacher changed the title tweak to README (docs) Move pbcopy to right place in example May 24, 2023
@ibacher ibacher merged commit 9e86ebc into main May 24, 2023
@ibacher ibacher deleted the readme-tweak branch May 24, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants